GSD autostarts: Changes suggestion #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following error message in the CI means the sysconfdir variable is set to `etc`:
session/meson.build:61:4: ERROR: File etc/xdg/autostart/org.gnome.SettingsDaemon.A11ySettings.desktop does not exist.
It points to `/etc` only when the prefix is set to `/usr` according to https://mesonbuild.com/Builtin-options.html:
When the prefix is /usr: sysconfdir defaults to /etc, localstatedir defaults to /var, and sharedstatedir defaults to /var/lib
ryonakano
changed the title
danirabbit
reviewed
Oct 7, 2024
| @@ -52,11 +52,12 @@ install_data( | |||
| install_dir: schemadir | |||
| ) | |||
|
|
|||
| vendor_prefix = 'pantheon' | |||
There was a problem hiding this comment.
We need to use a different prefix here or this package will conflict with our other session package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Summary
1. Set prefix to
/usrfor CIThe following error message in the CI means the sysconfdir variable is set to
etc:It points to
/etconly when the prefix is set to/usraccording to https://mesonbuild.com/Builtin-options.html:2. Fix vendor prefix
According to the man of
desktop-file-install, the value passed to the--vendoroption is used for the output file: