-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added: additional monitors and status info for cpu freq and vram usage #373
added: additional monitors and status info for cpu freq and vram usage #373
Conversation
added: additional status bar icons for gpu and vram fixed: nvidia vram indicator was displaying fb usage, not vram fixed: possible crash case when a gpu was not detected
Thanks for the PR! |
After building and installing, and restarting wingpanel I got this error for wingpanel
|
Ok, obviously I had indicator build and installation disabled |
As a note: I removed |
Codewise and naming is ok. I will try to polish UI a bit and will merge it. Thanks a lot! |
Cheers! Thank you |
I have removed vram from statusbar. It becomes too clunky IMO. |
Maybe adding gpu stuff to the status bar was a bit too much. I'd still keep the status info there if indicators are on, though. If people expect something to be somewhere it should be there, even if they've enabled showing it somewhere else. Don't go against expectations. |
This adds some displays for cpu frequency and vram usage on the indicator (I'm playing with amd-pstate at the moment, and wanted to be able to monitor the cpu freq on the fly)
I've also reordered them a little on the bar and added some separators in settings to hopefully group them a bit clearer.
I improvised a bit on the vram icon. Hopefully somebody else can improve or do something slight better.
I also added some more status bar items to show gpu and vram usage there.
While doing so I noticed that under nvidia the vram monitor wasn't actually showing percentage of vram usage, but fb usage. So I corrected that to show percentage of actual total vram in use, hopefully matching the intent and what happens under amd.
We also weren't ensuring
gpu != null
in one case (possible crash? :S) so I corrected that.I've not done anything about i18n. I don't know how that works :D (Do I need to run a script of some kind to update the translation strings?)