-
-
Notifications
You must be signed in to change notification settings - Fork 10
Getting it working #144
base: main
Are you sure you want to change the base?
Getting it working #144
Conversation
Hi @elijahd123 @alanschapira thank you for your PR! Would you like me to review this or is it not ready yet? If it isn't ready, please mark this review as a draft PR. Additionally, please fill out the PR template when you're ready. |
@elenirotsides Hey! This is ready for review now, and perhaps some QA testing too. |
Things to test
What happens if someone runs the slash command twice in the same channel? Are there any UI changes that you would like us to make? |
Oh my goodness this is incredible! 🤩 My personal computer has been unusable for a few months and have been unable to continue my work on this, so this PR is so so so appreciated! I actually have a new computer coming tomorrow, so I'll be able to take a look at all of this sometime this week. Again, thank you so so much for the time you both put into this; I will let you both know my thoughts soon! 🙌 @elijahd123 @alanschapira |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see all the comments I've made thus far and let me know if there are any questions. Additionally, please pull down the latest from main
as I've merged in some new code changes. I will do a more comprehensive code review once all my comments have been addressed. Thanks! @alanschapira @elijahd123
Im struggling to get the fork to merge with your main. Will try again later when I have time |
If you need help with the merge, let me know and I'd be happy to assist @alanschapira |
Hi guys @alanschapira @elijahd123 are you still working on this? Is there anything you need from me? I can take the work you've both done and continue on with it but if this is still actively being worked on, please let me know so I don't disrupt your flow. I'm very grateful to you both for this fantastic PR and am looking forward to getting the bot fully working again! |
Sorry I've been a bit too busy to finish this up. Feel free to take over at this point. You can use whatever you want and change whatever you want! In theory its working as is, but let me know if you cant get it working |
No problem, thanks for letting me know! And thanks for the PR; I'm excited to see slash commands working! I'll be messing around with this to give it the styling and functionality changes that I'm seeking but otherwise, the credit is all yours @alanschapira and @elijahd123 ! Excellent work, I really appreciate the help! |
Description
We have completely re-written the bot so that it works with slash commands and uses buttons instead of reactions.
Type of change
Checklist: