Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a .NET Standard project #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

TecVector
Copy link

This will enable this to be built into .NET Core and newer .NET Framework versions.

@elerch
Copy link
Owner

elerch commented Dec 2, 2019

How different is the SAML.Standard different from SAML2.Core? It looks like much of the new project is copied over, but it would help me if you can point at the significant differences.

@TecVector
Copy link
Author

It is mostly copied over - the main differences were just removal of some of the references and api calls that still had a reliance on the .NET framework. I ran the .NET profiler to see what the compatibility was, and followed those results. After successful completion, I was able to load that DLL into a .NET Core and Standard project w/o having any conflicts about how it was compiled. This was an issue I was seeing with the original SAML.Standard project. Most of the functionality is still in original form, so it is minor tweaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants