fix(network/worker): forget response token to prevent recursion on drop #149
+186
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this PR fixes the issue. We probably don't want to re-enter the drop with the same ResponseToken twice. This means we either check all possible outcomes and manually handle them with forget (which is error-prone and potentially dangerous in this case too and down the line), or we could use some kind of bitflags to mark tokens as responded. |
|
Ok, i agree, setting some kind of flag would be more robust approach in this case. |
loyd
reviewed
Jan 17, 2025
Erigara
force-pushed
the
fix_network_worker_recursion
branch
from
98537b5 to
1a31a39
Compare
Erigara
force-pushed
the
fix_network_worker_recursion
branch
from
1a31a39 to
24ea3e2
Compare
loyd
added a commit
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was observed that in case of panic on other side of network actor, response token ended up in endless recursion due
Dropimplementation.