New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: polyfill event emitter for property inspector #24

Merged

GeekyEggo merged 2 commits into main from events

Jan 20, 2024

Member

GeekyEggo commented Jan 1, 2024 •

edited

Loading

In preparation for adding a browser export, this pull request:

Adds an EventEmitter polyfill (available in Node.js, but not Chromium).
Updates our usage of node:events to use the polyfill; the underlying connection now uses the polyfill.
Introduces a strongly-typed event emitter, without the need for interfacing.
Centralizes the disposable listeners onto the EventEmitter class.
Removes the false-positive memory leaks by removing the concept of a "max listener count".
Exports the polyfill for re-usability.


          refactor: polyfill event emitter for property inspector

0f21c73

GeekyEggo requested a review from ChekTek

January 1, 2024 21:57


          feat: export polyfill for re-use

1474b06

ChekTek approved these changes

View reviewed changes

GeekyEggo merged commit fa2cd6d into main

2 checks passed

GeekyEggo deleted the events branch

January 20, 2024 17:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet