Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omnibus enhancements #9

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

arichtman
Copy link

@arichtman arichtman commented Sep 27, 2022

This is a large request so I'm happy to explain everything and adjust as we like.

  • Expose API feature to lint against a specific git ref
  • Add domain input validation
  • Automatically gather arguments from GitLab CI environment
  • Move from deprecated setup.py
  • Added debug logging
  • Adjust arguments so that short form flags don't clash
  • Change environment variable prefix to be shorter and managed by Click
  • Add --version option
  • Use commitizen to manage package versioning
  • Add pre-commit hooks for a variety of checks
  • Update README docs
  • Use common .gitignore template

@elijah-roberts
Copy link
Owner

Looks good... only sticking point will be the app version.. the latest I have deployed to pypi is 0.4.0.

What are your thoughts on releasing this changes as 1.0.0?

@arichtman

@elijah-roberts
Copy link
Owner

I will also need to update my CI pipline to build based on poetry but that should be easy enough

@arichtman
Copy link
Author

arichtman commented Sep 30, 2022

I would have liked to add some better tests before committing to an interface but I'm also fine with v1.0.0
After merge please run cz bump --increment MAJOR and then git push all, that will adjust the version to v1.0.0 and add Git tags. @elijah-roberts

@arichtman
Copy link
Author

I'm unsure if the ping reached you @elijah-roberts , please disregard if already notified.

@arichtman
Copy link
Author

arichtman commented Dec 15, 2022

@elijah-roberts Is this still good to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants