Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dynamic log channel #37

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Add support for dynamic log channel #37

merged 6 commits into from
Sep 23, 2024

Conversation

Sleepy4k
Copy link
Contributor

@Sleepy4k Sleepy4k commented Sep 8, 2024

Added support for dynamic log channel, instead of using default logging driver we can change it other logging driver as long as its exists on logging driver channel list

Copy link
Collaborator

@nea nea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sleepy4k , thanks for the PR. I have made some change requests before this could be added to the module. If you got questions, let me know. Thanks.

src/Database/Query/CacheableQueryBuilder.php Show resolved Hide resolved
src/Database/Query/CacheableQueryBuilder.php Outdated Show resolved Hide resolved
src/Database/Query/CacheableQueryBuilder.php Outdated Show resolved Hide resolved
@Sleepy4k Sleepy4k marked this pull request as draft September 8, 2024 19:34
@Sleepy4k Sleepy4k marked this pull request as ready for review September 8, 2024 23:09
@Sleepy4k
Copy link
Contributor Author

Sleepy4k commented Sep 9, 2024

Hai @nea, can you check for the latest commit, let me know if there is any issue or note

src/Database/Query/CacheableQueryBuilder.php Outdated Show resolved Hide resolved
src/Database/Query/CacheableQueryBuilder.php Outdated Show resolved Hide resolved
src/Models/Traits/Cacheable.php Outdated Show resolved Hide resolved
config/cacheable.php Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Sleepy4k
Copy link
Contributor Author

@nea hi, can you check the latest commit?

Copy link
Collaborator

@nea nea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR :)

@nea nea merged commit 2fed4d8 into elipZis:main Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants