-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update TES models to v1.1 #179
Conversation
Reviewer's Guide by SourceryThis pull request updates the TES models to version 1.1 by adding new fields and modifying existing ones in File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @athith-g - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. However, the one open Sourcery AI comment looks reasonable - although I have no clue if their suggested change works. Maybe you can try it out and either replace or comment on why it didn't work
Also - tests fail... |
I think the rest of the linting and integration tests will pass once #178 is merged. |
LGTM, @athith-g - I think you can merge :) |
Details
Added fields that were added in TES v1.1 to
models.py
TES v1.1 changes:
models.py
models.py
I removed the unnecessary newlines but I'm not sure how to achieve the whitespacing in the existing descriptions.
Summary by Sourcery
Updated TES models to v1.1 by adding new fields and states to support the latest features and configurations as per the TES v1.1 specification.