Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy info messages to the adapter #316

Merged
merged 8 commits into from
Nov 12, 2024
Merged

Proxy info messages to the adapter #316

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
da511ac
proxy info messages to the adapter
ruslandoga Nov 11, 2024
00c6958
add failing tests
ruslandoga Nov 11, 2024
ba7677a
update tcp_connection example
ruslandoga Nov 11, 2024
9fe84fc
add tests
ruslandoga Nov 11, 2024
595439a
add another failing test
ruslandoga Nov 11, 2024
a3ece3c
make test pass
ruslandoga Nov 11, 2024
a5cd7d7
cleanup
ruslandoga Nov 11, 2024
f4e74de
cleanup x2
ruslandoga Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions lib/db_connection/connection.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,12 +330,22 @@ defmodule DBConnection.Connection do
handle_timeout(s)
end

def handle_event(:info, msg, :no_state, %{mod: mod} = s) do
Logger.info(fn ->
[inspect(mod), ?\s, ?(, inspect(self()), ") missed message: " | inspect(msg)]
end)
def handle_event(:info, msg, :no_state, %{mod: mod, state: state} = s) do
if function_exported?(mod, :handle_info, 2) do
case apply(mod, :handle_info, [msg, state]) do
Copy link
Contributor Author

@ruslandoga ruslandoga Nov 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still passing the state to the callback since the monitor ref / socket ref would be there, and they are probably needed to match on the incoming message.

{:ok, state} ->
pool_update(state, s)
ruslandoga marked this conversation as resolved.
Show resolved Hide resolved

{:disconnect, err, state} ->
{:keep_state, %{s | state: state}, {:next_event, :internal, {:disconnect, {:log, err}}}}
ruslandoga marked this conversation as resolved.
Show resolved Hide resolved
end
else
Logger.info(fn ->
[inspect(mod), ?\s, ?(, inspect(self()), ") missed message: " | inspect(msg)]
end)

handle_timeout(s)
handle_timeout(s)
end
end

@doc false
Expand Down