Fix reporting errors from Oban #70
Conversation
|
Hey, that works great! I have tested this branch and now the error is tracked, and I can see the job details in the error context, as expected. Thanks! 🚀 |
lib/error_tracker/web/live/show.ex
Outdated
| defp error_has_source_info?(%Error{source_function: "-", source_line: "-"}), do: false | ||
| defp error_has_source_info?(%Error{}), do: true |
There was a problem hiding this comment.
Maybe we can move this function to ErrorTracker.Error.has_source_info? so we can reuse it both in show and dashboard templates. We are currently using it in the show template but doing the check manually in the dashboard template.
What do you think?
There was a problem hiding this comment.
Updated in e658416
There was a problem hiding this comment.
I've tested it before and after the change and it works perfectly.
I am wondering if we should add Oban as an optional dependency and create a test for this. Mainly to ensure that newer Oban versions don't break our assumptions.
Anyway this can be done later so feel free to merge it as-is.
There was an error when an Oban worker returned an `{:error, reason}`
tuple because Oban does not return an stacktrace (makes sense, as
it is not an exception by itself).
Our code was not prepared for that use case. I modified it to handle
it and circunvent the needed for source file and source function
information.
As an extra feature I have also added the reporting of the `state`
of the job (which is mostly ever `failure` for us).
odarriba
force-pushed
the
fix-report-errors-from-oban
branch
from
420c3dc to
288bc2d
Compare
odarriba
force-pushed
the
fix-report-errors-from-oban
branch
from
288bc2d to
e658416
Compare
There was an error when an Oban worker returned an
{:error, reason}tuple because Oban does not return an stacktrace (makes sense, as it is not an exception by itself).Our code was not prepared for that use case. I modified it to handle it and circumvent the needed for source file and source function information.
After this change, empty stack traces and source information are not shown on the dashboard to avoid confusion.
As an extra feature I have also added the reporting of the
stateof the job (which is mostly everfailurefor us).How to test
The way to reproduce it is to have an Oban worker which returns a tuple
{:error, any()}or just:error.That use case generates an exception in the latest release and works as expected on this branch.
Closes #63