Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker compose and GitHub actions #7

Merged
merged 13 commits into from
Apr 11, 2024
Merged

Fix docker compose and GitHub actions #7

merged 13 commits into from
Apr 11, 2024

Conversation

kdp-cloud
Copy link
Collaborator

@kdp-cloud kdp-cloud commented Mar 27, 2024 •
edited
Loading

  • Fixes the docker context for building the the BioSamples and ENA services
  • Fix GitHub actions
  • Caching pip dependencies

@kdp-cloud kdp-cloud force-pushed the test_workflow_branch branch from bbf39cb to 6b5bac2 Compare March 28, 2024 10:54
@kdp-cloud kdp-cloud changed the title Fix docker compose Fix docker compose and GitHub actions Mar 28, 2024
@kdp-cloud kdp-cloud marked this pull request as ready for review March 28, 2024 10:56
@kdp-cloud kdp-cloud requested a review from bedroesb March 28, 2024 10:56
bedroesb
bedroesb approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@bedroesb bedroesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for these additions! Note: I think we should add our coverage requirement in the pull request template/contribute guidelines.

@kdp-cloud kdp-cloud force-pushed the test_workflow_branch branch from 4dd8ebb to 4acbbf3 Compare April 11, 2024 06:06
bedroesb
bedroesb approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@bedroesb bedroesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@bedroesb bedroesb merged commit 8c79c35 into main Apr 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bedroesb bedroesb bedroesb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdp-cloud @bedroesb