added support for dictionary and fixed bugs #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocoa-xu
changed the title
josevalim
approved these changes
Jun 18, 2024
|
I don't know if we talked about this, but should it be s8, s16, etc for consistency with Nx and Explorer? |
Oh we haven't but I can change them in a minute! Should we keep the old ones for compatibility or just rename them and make it a breaking change? |
|
let's just rename them and make it a breaking change, i don't think anyone is using them yet. But we can make it in a separate PR! |
Ok I'll send a PR soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed some bugs and added support for encoding and decoding dictionary types.