Prepare for release v0.7.2 #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We mention that multiple times in our modules.
philss
commented
Nov 30, 2023
| @@ -77,6 +77,9 @@ defmodule Explorer.MixProject do | |||
| Explorer.Backend.LazyFrame, | |||
| Explorer.Backend.LazySeries, | |||
| Explorer.PolarsBackend | |||
| ], | |||
| Internal: [ | |||
| Explorer.Duration | |||
There was a problem hiding this comment.
I'm not sure about this division, but I wanted to keep this separated. I chose to document the module because we refer to it in many places - mostly typespecs.
There was a problem hiding this comment.
Especially because if a user does to_list to a duration series, they'll see these structs.
There was a problem hiding this comment.
@billylanchantin thanks! And sorry for merging it too fast 😬
If you find anything here, please let me know so I can fix before the release.
There was a problem hiding this comment.
Yep! I'm happy with this as well. Nice :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.