-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix where in array + dynamic limit and offset #171
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 328
💛 - Coveralls |
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/ankhers/mongodb_ecto/pulls/171. |
defp where_params_range({:not, _, [expr]}), do: where_params_range(expr) | ||
|
||
defp where_params_range({_, _, exprs}) do | ||
ranges = Enum.map(exprs, &where_params_range(&1)) |> Enum.filter(& &1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a function call when a pipeline is only one function long
OK, I'm at a point when I think that it all works incorrectly 😭 I wrote a more complicated test case and tried to make it work: It uses these params:
but generates this expression:
|
Fixes #170