-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch underlying driver to mongodb_driver for MongoDB 6.0+ support #190
Conversation
…one/3 Basing staleness on the modified_count is incorrect, since updates that match a document but leave it as-is is a successful no-op. The action should only be considered stale if the update query did not match any documents.
Thanks so much, @brennana! I'm excited to review this. In looking over the commits, it seems like there's shockingly little to change. Exciting! |
The MongoDB driver 1.4.0 contains the changes needed for this PR. |
Thank you @zookzook! |
…into hundio_switch-mongodb-driver
Hey @brennana, I'll be testing out the PR this week! Could you allow changes to your branch? I'll push fixes for the CI and make any revisions if needed. |
Hi @mweidner037, I have added you for write access to our fork of the repo. Let me know if you need anything else. For whatever reason, there does not seem to be an option to allow collaborators access to our fork through this PR, as per the GitHub documentation you linked. Perhaps it's because the fork is owned by my organization, not sure. |
Thanks! I've tested this out in our app and found no issues. For apps that call the
I'll merge this and start on a migration guide for the next release. |
Thank you for your work, everybody. I'm going through this upgrade because of Atlas's force upgrade EOM. this is well appreciated. The cut over on the ecto queries was super smooth. I find myself only needing to update the direct Mongo aggregation queries. |
This PR switches the adapter over to https://github.com/zookzook/elixir-mongodb-driver .
Currently, the mix.exs/mix.lock file is pointed at our fork at https://github.com/hundio/elixir-mongodb-driver until a Hex release is made with the required adapter compatibility changes.The mix.exs file now points to mongodb_driver 1.4.0, rather than our own repository.Upgrading from one driver to the other is fairly transparent for users of the Ecto adapter (unless direct calls to the driver are made outside the adapter):
pool
,pool_overflow
,pool_timeout
.pool
option is no longer accepted byMongo
database command functionsMongo
module cannot be passed aPool
module from the Repo any longer; instead, a pool PID is expected: