Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typespec/1 macro to transform module behaviour #384

Merged
merged 8 commits into from
Dec 25, 2024
+105 −33
Merged

Add typespec/1 macro to transform module behaviour #384

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a6c4647
When module has transform_module, use it on typespec
v0idpwn Dec 4, 2024
443cbd6
Fix warning
v0idpwn Dec 4, 2024
3ea9f46
Add type t/1 to transform modules
v0idpwn Dec 4, 2024
89cbb00
Implement new idea for typespecs on transformers
v0idpwn Dec 18, 2024
697eac7
Update lib/protobuf/transform_module/infer_fields_from_enum.ex
v0idpwn Dec 18, 2024
2723492
Take a single argument in typespec macro
v0idpwn Dec 22, 2024
02daaf4
Address review comments
v0idpwn Dec 22, 2024
b9c00da
Remove comp-time error
v0idpwn Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review comments
@v0idpwn
v0idpwn committed Dec 22, 2024
commit 02daaf47b4ca0f1c7515cbd2d469132d7b829901
6 changes: 3 additions & 3 deletions lib/protobuf/dsl.ex
View file
Original file line number Diff line number Diff line change
@@ -254,11 +254,11 @@ defmodule Protobuf.DSL do
_ ->
raise CompileError, """
Transform module #{inspect(unquote(transform_module_ast))} not available
during protobuf definition compilation.
during Protobuf definition compilation.

Since protobuf v0.14, protobuf definitions depend in compile time on
Since Protobuf v0.14, Protobuf definitions depend in compile time on
their transform modules. This means that transform modules can't depend
on protobuf structs, and must be available for compilation when protobuf
on Protobuf structs, and must be available for compilation when Protobuf
definitions are compiled.
"""
end
2 changes: 1 addition & 1 deletion lib/protobuf/transform_module.ex
View file
Original file line number Diff line number Diff line change
@@ -62,7 +62,7 @@ defmodule Protobuf.TransformModule do
@callback decode(message(), type()) :: value()

@doc """
Transforms the typespec for modules using this transformer
Transforms the typespec for modules using this transformer.

If this callback is not present, the default typespec will be used.
"""

Unchanged files with check annotations Beta

View file
test/support/test_msg.ex
@impl true
defmacro typespec(default_typespec) do
case module do

Check warning on line 259 in test/support/test_msg.ex

GitHub Actions / Test (Elixir 1.12.3 | Erlang/OTP 24.3) 

variable "module" does not exist and is being expanded to "module()", please use parentheses to remove the ambiguity or change the variable name

Check failure on line 259 in test/support/test_msg.ex

GitHub Actions / Test (Elixir 1.12.3 | Erlang/OTP 24.3) 

** (CompileError) test/support/test_msg.ex:259: undefined function module/0

Check warning on line 259 in test/support/test_msg.ex

GitHub Actions / Conformance test (Elixir 1.14 | Erlang/OTP 24.2) 

variable "module" does not exist and is being expanded to "module()", please use parentheses to remove the ambiguity or change the variable name

Check failure on line 259 in test/support/test_msg.ex

GitHub Actions / Conformance test (Elixir 1.14 | Erlang/OTP 24.2) 

** (CompileError) test/support/test_msg.ex:259: undefined function module/0 (expected TestMsg.TransformModule to define such a function or for it to be imported, but none are available)
WithTransformModule ->
quote do
@type t() :: integer()