Add native Elixir JSON support
#394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation defaults to `JSON` if it's available. If it's not, it tries to use `Jason` as it did before. Some exceptions are changed (only for `JSON`, `Jason` is unaffected). For example, instead of `Jason.DecodeError`, when using `JSON` we raise `Protobuf.JSON.DecodeError`, and encode errors have a more varied shape (since they can be mostly anything coming from Elixir side).
|
If we don't want to default to it, we can make it configurable and keep the default as Jason. But I don't see good reasons for that. |
v0idpwn
commented
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation defaults to
JSONif it's available. If it's not,it tries to use
Jasonas it did before.Some exceptions are changed (only for
JSON,Jasonis unaffected). Forexample, instead of
Jason.DecodeError, when usingJSONwe raiseProtobuf.JSON.DecodeError, and encode errors have a more varied shape(since they can be mostly anything coming from Elixir side).
Additionally, it adds 1.18.1 in CI. Once it's working in both versions, I'll
remove 1.17.x.