Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to warn against using different escript and deps versions. #400

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

m1dnight
Copy link
Contributor

Ive spent a good amount of time figuring out why our protobufs didnt compile anymore.

It turned out that the version being installed in the CI was 0.14 and not 0.11 as in the application.

I added a warning for this to the readme, because I feel it could save other people a lot of time.

Perhaps for the Google machine, the error I got was the following:

** (KeyError) key :features not found
    (protobuf 0.11.0) expanding struct: Google.Protobuf.MethodOptions.__struct__/1
    lib/protobuf/indexer_service.pb.ex:13: IndexerService.Service.descriptor/0```

@v0idpwn
Copy link
Collaborator

v0idpwn commented Jan 20, 2025

This seems about right.

I wonder if we could verify it. Generally we are backwards compatible in the library, but potentially not in the escript. So we'd need to check when compiling if the generated-module version is higher than the running library version, and warn.

@v0idpwn v0idpwn merged commit a7d4e96 into elixir-protobuf:main Jan 20, 2025
4 checks passed
@v0idpwn
Copy link
Collaborator

v0idpwn commented Jan 20, 2025

Thanks! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants