Add mock function into Timeout Task's process dictionary #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 95.65% 95.68% +0.02%
==========================================
Files 23 23
Lines 460 463 +3
==========================================
+ Hits 440 443 +3
Misses 20 20
Continue to review full report at Codecov.
|
|
Thanks for the PR! The reason I did not implement this solution is that it is polluting production code with test-specific code. Please see #240 (point C) for the proposal on how to fix this issue. |
|
It makes totally sense. I'll take a closer look on #240. Closing for now. Thanks :) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This is a proposal to fix #157.
I followed @stefanchrobot first suggestion and copied the mock inside
Taskprocess dictionary.On the unit tests, I had to define another client since I couldn't figure out a way to reuse the existing one's for this test. Would appreciate any feedback on how to improve it :)