feat: add ssl opt to httpc by default #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yordis
force-pushed
the
add-ssl-to-httpc-by-default
branch
6 times, most recently
from
cf9bb33 to
519a138
Compare
maennchen
reviewed
Oct 11, 2023
yordis
force-pushed
the
add-ssl-to-httpc-by-default
branch
5 times, most recently
from
ee7f55a to
14cd5f6
Compare
|
@maennchen do you know what am I am doing wrong that the SSL is not returning an error, but logging it
https://github.com/elixir-tesla/tesla/actions/runs/9739093158/job/26873718685?pr=626#step:6:1048 |
yordis
force-pushed
the
add-ssl-to-httpc-by-default
branch
from
14cd5f6 to
5efb69b
Compare
fixes #293 Signed-off-by: Yordis Prieto <[email protected]>
yordis
force-pushed
the
add-ssl-to-httpc-by-default
branch
8 times, most recently
from
8f5e0a5 to
8bd15b9
Compare
yordis
requested review from
maennchen and
teamon
and removed request for
maennchen
yordis
force-pushed
the
add-ssl-to-httpc-by-default
branch
from
8bd15b9 to
fc45aac
Compare
yordis
force-pushed
the
add-ssl-to-httpc-by-default
branch
from
fc45aac to
c534b28
Compare
|
@teamon @maennchen ready to code review 🙏🏻 |
yordis
added a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #293
Signed-off-by: Yordis Prieto [email protected]