Adds Deadline.time_exceeded\1
#5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I often find myself wanting to get the time that we have blown past the deadline for logging, debugging, or generally gathering more information about the response times of down stream services. Since we are using Deadline for ensuring that we don't continue to wait around I often find myself pulling the deadline time out of the context and then copying how `Deadline.time_remaining\1` works, b ut swapping the subtraction. It would nice to be able to not have to worry about the internal workings of Deadline and get the information straight from Deadline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often want to get the time that we have blown past
the deadline for logging, debugging, or gathering more
information about the response times of downstream services. Since we
are using Deadline for ensuring that we don't continue to wait around
I often find myself pulling the deadline time out of the context and
then copying how
Deadline.time_remaining\1works, but swapping thesubtraction. It would be nice not to worry about Deadline's internal workings
and get the information straight from Deadline.
#NogginDay