Skip to content

Commit

Permalink
Generate answer from RTPTransceivers
Browse files Browse the repository at this point in the history
  • Loading branch information
mickel8 committed Oct 23, 2023
1 parent d19d6c9 commit 31c1a79
Show file tree
Hide file tree
Showing 6 changed files with 142 additions and 66 deletions.
6 changes: 5 additions & 1 deletion examples/example.exs
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ defmodule Peer do
end

@impl true
def handle_info({:ex_webrtc, msg}, state) do
def handle_info({:ex_webrtc, _pid, msg}, state) do
Logger.info("Received ExWebRTC message: #{inspect(msg)}")
handle_webrtc_message(msg, state)

Expand Down Expand Up @@ -119,6 +119,10 @@ defmodule Peer do
:gun.ws_send(state.conn, state.stream, {:text, Jason.encode!(msg)})

end

defp handle_webrtc_message(msg, _state) do
Logger.warning("Received unknown ex_webrtc message: #{inspect(msg)}")
end
end

{:ok, pid} = Peer.start_link()
Expand Down
95 changes: 34 additions & 61 deletions lib/ex_webrtc/peer_connection.ex
Original file line number Diff line number Diff line change
Expand Up @@ -32,42 +32,6 @@ defmodule ExWebRTC.PeerConnection do
signaling_state: :stable
]

@dummy_sdp """
v=0
o=- 7596991810024734139 2 IN IP4 127.0.0.1
s=-
t=0 0
a=group:BUNDLE 0
a=extmap-allow-mixed
a=msid-semantic: WMS
m=audio 9 UDP/TLS/RTP/SAVPF 111 63 9 0 8 13 110 126
c=IN IP4 0.0.0.0
a=rtcp:9 IN IP4 0.0.0.0
a=ice-ufrag:vx/1
a=ice-pwd:ldFUrCsXvndFY2L1u0UQ7ikf
a=ice-options:trickle
a=fingerprint:sha-256 76:61:77:1E:7C:2E:BB:CD:19:B5:27:4E:A7:40:84:06:6B:17:97:AB:C4:61:90:16:EE:96:9F:9E:BD:42:96:3D
a=setup:passive
a=mid:0
a=extmap:1 urn:ietf:params:rtp-hdrext:ssrc-audio-level
a=extmap:2 http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time
a=extmap:3 http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01
a=extmap:4 urn:ietf:params:rtp-hdrext:sdes:mid
a=recvonly
a=rtcp-mux
a=rtpmap:111 opus/48000/2
a=rtcp-fb:111 transport-cc
a=fmtp:111 minptime=10;useinbandfec=1
a=rtpmap:63 red/48000/2
a=fmtp:63 111/111
a=rtpmap:9 G722/8000
a=rtpmap:0 PCMU/8000
a=rtpmap:8 PCMA/8000
a=rtpmap:13 CN/8000
a=rtpmap:110 telephone-event/48000
a=rtpmap:126 telephone-event/8000
"""

#### API ####

def start_link(configuration \\ []) do
Expand Down Expand Up @@ -147,36 +111,45 @@ defmodule ExWebRTC.PeerConnection do
@impl true
def handle_call({:create_answer, _options}, _from, state)
when state.signaling_state in [:have_remote_offer, :have_local_pranswer] do
{:ok, ufrag, pwd} = ICEAgent.get_local_credentials(state.ice_agent)

{:ok, ice_ufrag, ice_pwd} = ICEAgent.get_local_credentials(state.ice_agent)

Check warning on line 114 in lib/ex_webrtc/peer_connection.ex

View check run for this annotation

Codecov / codecov/patch

lib/ex_webrtc/peer_connection.ex#L114

Added line #L114 was not covered by tests
{:ok, dtls_fingerprint} = ExDTLS.get_cert_fingerprint(state.dtls_client)

sdp = ExSDP.parse!(@dummy_sdp)
media = hd(sdp.media)

attrs =
Enum.map(media.attributes, fn
{:ice_ufrag, _} ->
{:ice_ufrag, ufrag}

{:ice_pwd, _} ->
{:ice_pwd, pwd}

{:fingerprint, {hash_function, _}} ->
{:fingerprint, {hash_function, hex_dump(dtls_fingerprint)}}

other ->
other
answer = %ExSDP{ExSDP.new() | timing: %ExSDP.Timing{start_time: 0, stop_time: 0}}

Check warning on line 117 in lib/ex_webrtc/peer_connection.ex

View check run for this annotation

Codecov / codecov/patch

lib/ex_webrtc/peer_connection.ex#L117

Added line #L117 was not covered by tests

config =

Check warning on line 119 in lib/ex_webrtc/peer_connection.ex

View check run for this annotation

Codecov / codecov/patch

lib/ex_webrtc/peer_connection.ex#L119

Added line #L119 was not covered by tests
[
ice_ufrag: ice_ufrag,
ice_pwd: ice_pwd,
ice_options: "trickle",
fingerprint: {:sha256, hex_dump(dtls_fingerprint)},
# TODO offer will always contain actpass
# and answer should contain active
# see RFC 8829 sec. 5.3.1
setup: :passive
]

mlines =
Enum.map(state.transceivers, fn transceiver ->
RTPTransceiver.to_mline(transceiver, config)

Check warning on line 133 in lib/ex_webrtc/peer_connection.ex

View check run for this annotation

Codecov / codecov/patch

lib/ex_webrtc/peer_connection.ex#L131-L133

Added lines #L131 - L133 were not covered by tests
end)

media = Map.put(media, :attributes, attrs)

sdp =
sdp
|> Map.put(:media, [media])
|> to_string()
mids =

Check warning on line 136 in lib/ex_webrtc/peer_connection.ex

View check run for this annotation

Codecov / codecov/patch

lib/ex_webrtc/peer_connection.ex#L136

Added line #L136 was not covered by tests
Enum.map(mlines, fn mline ->
{:mid, mid} = ExSDP.Media.get_attribute(mline, :mid)
mid

Check warning on line 139 in lib/ex_webrtc/peer_connection.ex

View check run for this annotation

Codecov / codecov/patch

lib/ex_webrtc/peer_connection.ex#L138-L139

Added lines #L138 - L139 were not covered by tests
end)

desc = %SessionDescription{type: :answer, sdp: sdp}
answer =

Check warning on line 142 in lib/ex_webrtc/peer_connection.ex

View check run for this annotation

Codecov / codecov/patch

lib/ex_webrtc/peer_connection.ex#L142

Added line #L142 was not covered by tests
answer
|> ExSDP.add_attributes([
%ExSDP.Attribute.Group{semantics: "BUNDLE", mids: mids},
# always allow for mixing one- and two-byte RTP header extensions
# TODO ensure this was also offered
"extmap-allow-mixed"
])
|> ExSDP.add_media(mlines)

desc = %SessionDescription{type: :answer, sdp: to_string(answer)}

Check warning on line 152 in lib/ex_webrtc/peer_connection.ex

View check run for this annotation

Codecov / codecov/patch

lib/ex_webrtc/peer_connection.ex#L152

Added line #L152 was not covered by tests
{:reply, {:ok, desc}, state}
end

Expand Down
18 changes: 18 additions & 0 deletions lib/ex_webrtc/rtp_codec_parameters.ex
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
defmodule ExWebRTC.RTPCodecParameters do
@moduledoc """
RTPCodecParameters
"""

defstruct [:payload_type, :mime_type, :clock_rate, :channels, :sdp_fmtp_line, :rtcp_fbs]

def new(type, rtp_mapping, fmtp, rtcp_fbs) do
%__MODULE__{
payload_type: rtp_mapping.payload_type,
mime_type: "#{type}/#{rtp_mapping.encoding}",
clock_rate: rtp_mapping.clock_rate,
channels: rtp_mapping.params,
sdp_fmtp_line: fmtp,
rtcp_fbs: rtcp_fbs
}
end
end
3 changes: 3 additions & 0 deletions lib/ex_webrtc/rtp_receiver.ex
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
defmodule ExWebRTC.RTPReceiver do

Check warning on line 1 in lib/ex_webrtc/rtp_receiver.ex

View workflow job for this annotation

GitHub Actions / Lint (OTP 26 / Elixir 1.15)

Modules should have a @moduledoc tag.
defstruct [:ssrc]
end
83 changes: 79 additions & 4 deletions lib/ex_webrtc/rtp_transceiver.ex
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,19 @@ defmodule ExWebRTC.RTPTransceiver do
RTPTransceiver
"""

alias ExWebRTC.{RTPCodecParameters, RTPReceiver}

@type t() :: %__MODULE__{
mid: String.t(),
direction: :sendonly | :recvonly | :sendrecv | :inactive | :stopped,
kind: :audio | :video
kind: :audio | :video,
hdr_exts: [],
codecs: [],
rtp_receiver: nil
}

@enforce_keys [:mid, :direction, :kind]
defstruct @enforce_keys
defstruct @enforce_keys ++ [codecs: [], hdr_exts: [], rtp_receiver: %RTPReceiver{}]

@doc false
def find_by_mid(transceivers, mid) do
Expand All @@ -30,9 +35,79 @@ defmodule ExWebRTC.RTPTransceiver do
List.replace_at(transceivers, idx, update(tr, mline))

nil ->
transceivers ++ [%__MODULE__{mid: mid, direction: :recvonly, kind: mline.type}]
codecs = get_codecs(mline)
hdr_exts = ExSDP.Media.get_attributes(mline, ExSDP.Attribute.Extmap)
ssrc = ExSDP.Media.get_attributes(mline, ExSDP.Attribute.SSRC)

tr = %__MODULE__{
mid: mid,
direction: :recvonly,
kind: mline.type,
codecs: codecs,
hdr_exts: hdr_exts,
rtp_receiver: %RTPReceiver{ssrc: ssrc}
}

transceivers ++ [tr]
end
end

defp update(transceiver, _mline), do: transceiver
def to_mline(transceiver, config) do
pt = Enum.map(transceiver.codecs, fn codec -> codec.payload_type end)

Check warning on line 56 in lib/ex_webrtc/rtp_transceiver.ex

View check run for this annotation

Codecov / codecov/patch

lib/ex_webrtc/rtp_transceiver.ex#L56

Added line #L56 was not covered by tests

media_formats =
Enum.flat_map(transceiver.codecs, fn codec ->
[_type, encoding] = String.split(codec.mime_type, "/")

Check warning on line 60 in lib/ex_webrtc/rtp_transceiver.ex

View check run for this annotation

Codecov / codecov/patch

lib/ex_webrtc/rtp_transceiver.ex#L58-L60

Added lines #L58 - L60 were not covered by tests

rtp_mapping = %ExSDP.Attribute.RTPMapping{
clock_rate: codec.clock_rate,

Check warning on line 63 in lib/ex_webrtc/rtp_transceiver.ex

View check run for this annotation

Codecov / codecov/patch

lib/ex_webrtc/rtp_transceiver.ex#L62-L63

Added lines #L62 - L63 were not covered by tests
encoding: encoding,
params: codec.channels,
payload_type: codec.payload_type

Check warning on line 66 in lib/ex_webrtc/rtp_transceiver.ex

View check run for this annotation

Codecov / codecov/patch

lib/ex_webrtc/rtp_transceiver.ex#L65-L66

Added lines #L65 - L66 were not covered by tests
}

[rtp_mapping, codec.sdp_fmtp_line, codec.rtcp_fbs]

Check warning on line 69 in lib/ex_webrtc/rtp_transceiver.ex

View check run for this annotation

Codecov / codecov/patch

lib/ex_webrtc/rtp_transceiver.ex#L69

Added line #L69 was not covered by tests
end)

%ExSDP.Media{
ExSDP.Media.new(transceiver.kind, 9, "UDP/TLS/RTP/SAVPF", pt)

Check warning on line 73 in lib/ex_webrtc/rtp_transceiver.ex

View check run for this annotation

Codecov / codecov/patch

lib/ex_webrtc/rtp_transceiver.ex#L72-L73

Added lines #L72 - L73 were not covered by tests
| # mline must be followed by a cline, which must contain
# the default value "IN IP4 0.0.0.0" (as there are no candidates yet)
connection_data: [%ExSDP.ConnectionData{address: {0, 0, 0, 0}}]
}
|> ExSDP.Media.add_attributes([
transceiver.direction,
{:mid, transceiver.mid},

Check warning on line 80 in lib/ex_webrtc/rtp_transceiver.ex

View check run for this annotation

Codecov / codecov/patch

lib/ex_webrtc/rtp_transceiver.ex#L79-L80

Added lines #L79 - L80 were not covered by tests
{:ice_ufrag, Keyword.fetch!(config, :ice_ufrag)},
{:ice_pwd, Keyword.fetch!(config, :ice_pwd)},
{:ice_options, Keyword.fetch!(config, :ice_options)},
{:fingerprint, Keyword.fetch!(config, :fingerprint)},
{:setup, Keyword.fetch!(config, :setup)},
:rtcp_mux
])
|> ExSDP.Media.add_attributes(media_formats)

Check warning on line 88 in lib/ex_webrtc/rtp_transceiver.ex

View check run for this annotation

Codecov / codecov/patch

lib/ex_webrtc/rtp_transceiver.ex#L88

Added line #L88 was not covered by tests
end

defp update(transceiver, mline) do
codecs = get_codecs(mline)
hdr_exts = ExSDP.Media.get_attributes(mline, ExSDP.Attribute.Extmap)
ssrc = ExSDP.Media.get_attributes(mline, ExSDP.Attribute.SSRC)
rtp_receiver = %RTPReceiver{ssrc: ssrc}
%__MODULE__{transceiver | codecs: codecs, hdr_exts: hdr_exts, rtp_receiver: rtp_receiver}
end

defp get_codecs(mline) do
rtp_mappings = ExSDP.Media.get_attributes(mline, ExSDP.Attribute.RTPMapping)
fmtps = ExSDP.Media.get_attributes(mline, ExSDP.Attribute.FMTP)
all_rtcp_fbs = ExSDP.Media.get_attributes(mline, ExSDP.Attribute.RTCPFeedback)

for rtp_mapping <- rtp_mappings do
fmtp = Enum.find(fmtps, fn fmtp -> fmtp.pt == rtp_mapping.payload_type end)

rtcp_fbs =
Enum.filter(all_rtcp_fbs, fn rtcp_fb -> rtcp_fb.pt == rtp_mapping.payload_type end)

RTPCodecParameters.new(mline.type, rtp_mapping, fmtp, rtcp_fbs)
end
end
end
3 changes: 3 additions & 0 deletions test/peer_connection_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ defmodule ExWebRTC.PeerConnectionTest do
"""

test "transceivers" do
IO.inspect(ExSDP.parse(@audio_video_offer))
{:ok, pc} = PeerConnection.start_link()

offer = %SessionDescription{type: :offer, sdp: @single_audio_offer}
Expand All @@ -92,6 +93,8 @@ defmodule ExWebRTC.PeerConnectionTest do
offer = %SessionDescription{type: :offer, sdp: @audio_video_offer}
:ok = PeerConnection.set_remote_description(pc, offer)

IO.inspect(PeerConnection.get_transceivers(pc))

Check warning on line 96 in test/peer_connection_test.exs

View workflow job for this annotation

GitHub Actions / Lint (OTP 26 / Elixir 1.15)

There should be no calls to IO.inspect/1.

assert_receive {:ex_webrtc, ^pc, {:track, %MediaStreamTrack{mid: "1", kind: :video}}}
refute_receive {:ex_webrtc, ^pc, {:track, %MediaStreamTrack{}}}
end
Expand Down

0 comments on commit 31c1a79

Please sign in to comment.