Improve UX of Configuration (#120)

elixir-webrtc · Jun 25, 2024 · 8b0af9e · 8b0af9e
1 parent 2fb532b
commit 8b0af9e
Show file tree

Hide file tree

Showing 18 changed files with 1,094 additions and 701 deletions.
diff --git a/examples/echo/lib/echo/peer_handler.ex b/examples/echo/lib/echo/peer_handler.ex
@@ -19,14 +19,7 @@ defmodule Echo.PeerHandler do
     %RTPCodecParameters{
       payload_type: 96,
       mime_type: "video/VP8",
-      clock_rate: 90_000,
-      rtcp_fbs: [%ExSDP.Attribute.RTCPFeedback{pt: 96, feedback_type: :nack}]
-    },
-    %RTPCodecParameters{
-      payload_type: 97,
-      mime_type: "video/rtx",
-      clock_rate: 90_000,
-      sdp_fmtp_line: %ExSDP.Attribute.FMTP{pt: 97, apt: 96}
+      clock_rate: 90_000
     }
   ]
 

diff --git a/examples/save_to_file/lib/save_to_file/peer_handler.ex b/examples/save_to_file/lib/save_to_file/peer_handler.ex
@@ -25,14 +25,7 @@ defmodule SaveToFile.PeerHandler do
     %RTPCodecParameters{
       payload_type: 96,
       mime_type: "video/VP8",
-      clock_rate: 90_000,
-      rtcp_fbs: [%ExSDP.Attribute.RTCPFeedback{pt: 96, feedback_type: :nack}]
-    },
-    %RTPCodecParameters{
-      payload_type: 97,
-      mime_type: "video/rtx",
-      clock_rate: 90_000,
-      sdp_fmtp_line: %ExSDP.Attribute.FMTP{pt: 97, apt: 96}
+      clock_rate: 90_000
     }
   ]
 

diff --git a/examples/send_from_file/lib/send_from_file/peer_handler.ex b/examples/send_from_file/lib/send_from_file/peer_handler.ex
@@ -30,14 +30,7 @@ defmodule SendFromFile.PeerHandler do
     %RTPCodecParameters{
       payload_type: 96,
       mime_type: "video/VP8",
-      clock_rate: 90_000,
-      rtcp_fbs: [%ExSDP.Attribute.RTCPFeedback{pt: 96, feedback_type: :nack}]
-    },
-    %RTPCodecParameters{
-      payload_type: 97,
-      mime_type: "video/rtx",
-      clock_rate: 90_000,
-      sdp_fmtp_line: %ExSDP.Attribute.FMTP{pt: 97, apt: 96}
+      clock_rate: 90_000
     }
   ]
 

diff --git a/examples/whip_whep/lib/whip_whep/peer_supervisor.ex b/examples/whip_whep/lib/whip_whep/peer_supervisor.ex
@@ -18,14 +18,7 @@ defmodule WhipWhep.PeerSupervisor do
     %RTPCodecParameters{
       payload_type: 96,
       mime_type: "video/H264",
-      clock_rate: 90_000,
-      rtcp_fbs: [%ExSDP.Attribute.RTCPFeedback{pt: 96, feedback_type: :nack}]
-    },
-    %RTPCodecParameters{
-      payload_type: 97,
-      mime_type: "video/rtx",
-      clock_rate: 90_000,
-      sdp_fmtp_line: %ExSDP.Attribute.FMTP{pt: 97, apt: 96}
+      clock_rate: 90_000
     }
   ]
 

diff --git a/lib/ex_webrtc/media/ogg/page.ex b/lib/ex_webrtc/media/ogg/page.ex
@@ -37,7 +37,7 @@ defmodule ExWebRTC.Media.Ogg.Page do
                 rest: <<>>
               ]
 
-  @spec read(File.io_device()) :: {:ok, t()} | {:error, term()}
+  @spec read(File.io_device()) :: {:ok, t()} | {:error, term()} | :eof
   def read(file) do
     with <<@signature, @version, type, granule_pos::little-64, serial_no::little-32,
            sequence_no::little-32, _checksum::little-32,