Handle server side DTLS handshake #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
force-pushed
the
dtls
branch
5 times, most recently
from
14b02d6 to
a78114b
Compare
mickel8
force-pushed
the
dtls
branch
2 times, most recently
from
9e052d3 to
64c1872
Compare
LVala
approved these changes
Oct 17, 2023
lib/ex_webrtc/peer_connection.ex
Outdated
Comment on lines
243
to
245
| {:handshake_packets, packets} when state.ice_state in [:connected, :completed] -> | ||
| :ok = ICEAgent.send_data(state.ice_agent, packets) | ||
|
|
There was a problem hiding this comment.
no {:noreply, ...} return value in this arm of the case block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for server side DTLS handshake i.e. we always act as a server and the other side must always initiate the handshake