Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document and refactor PeerConnection options #11

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Document and refactor PeerConnection options #11

merged 1 commit into from
Nov 6, 2023

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Nov 3, 2023

No description provided.

@mickel8 mickel8 requested a review from LVala November 3, 2023 13:18
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
lib/ex_webrtc/session_description.ex 0.00% <ø> (ø)
lib/ex_webrtc/peer_connection.ex 68.94% <66.66%> (-5.47%) ⬇️
lib/ex_webrtc/peer_connection/configuration.ex 57.89% <71.42%> (+7.89%) ⬆️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@mickel8 mickel8 removed the request for review from LVala November 4, 2023 08:55
LVala
LVala reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@LVala LVala left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed, use the formatter pls.

@mickel8 mickel8 requested a review from LVala November 6, 2023 10:45
@mickel8 mickel8 merged commit d86ac87 into master Nov 6, 2023
2 checks passed
@mickel8 mickel8 deleted the pc-opts branch November 6, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LVala LVala LVala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickel8 @LVala