Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataChannels: allow for closing, apply negotiated stream parameters #161

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

LVala
Copy link
Member

@LVala LVala commented Aug 27, 2024

No description provided.

@LVala LVala self-assigned this Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 70.21277% with 14 lines in your changes missing coverage. Please review.

Project coverage is 87.58%. Comparing base (637f2d7) to head (b6734af).
Report is 1 commits behind head on master.

Files Patch % Lines
lib/ex_webrtc/sctp_transport.ex 65.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   87.82%   87.58%   -0.24%     
==========================================
  Files          40       40              
  Lines        2160     2199      +39     
==========================================
+ Hits         1897     1926      +29     
- Misses        263      273      +10     
Files Coverage Δ
lib/ex_webrtc/peer_connection.ex 85.84% <100.00%> (+0.14%) ⬆️
lib/ex_webrtc/sctp_transport.ex 81.25% <65.00%> (-3.58%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 637f2d7...b6734af. Read the comment docs.

@LVala LVala marked this pull request as ready for review August 27, 2024 15:30
@LVala LVala requested review from mickel8 and sgfn August 27, 2024 15:32
@LVala LVala merged commit 8109856 into master Aug 28, 2024
3 checks passed
@LVala LVala deleted the data-channels-2 branch August 28, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants