Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DataChannel support optional #163

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Make DataChannel support optional #163

merged 3 commits into from
Aug 29, 2024

Conversation

LVala
Copy link
Member

@LVala LVala commented Aug 28, 2024

Now the user is forced to use ex_sctp and therefore needs to install Rust. This PR makes the ex_sctp dependency and DataChannel support as a whole optional.

@LVala LVala self-assigned this Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 82.55814% with 30 lines in your changes missing coverage. Please review.

Project coverage is 87.58%. Comparing base (e79d429) to head (1940150).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/ex_webrtc/sctp_transport.ex 82.45% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   87.64%   87.58%   -0.06%     
==========================================
  Files          40       40              
  Lines        2225     2231       +6     
==========================================
+ Hits         1950     1954       +4     
- Misses        275      277       +2     
Files with missing lines Coverage Δ
lib/ex_webrtc/peer_connection.ex 85.90% <100.00%> (ø)
lib/ex_webrtc/sctp_transport.ex 82.08% <82.45%> (-0.56%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79d429...1940150. Read the comment docs.

@LVala LVala force-pushed the optional-channels branch from 6a91bcd to f8f41b3 Compare August 29, 2024 10:33
@LVala LVala force-pushed the optional-channels branch from f8f41b3 to ddda727 Compare August 29, 2024 10:54
@LVala LVala force-pushed the optional-channels branch from 9d57d99 to 2c79728 Compare August 29, 2024 11:19
@LVala LVala marked this pull request as ready for review August 29, 2024 11:27
@LVala LVala requested review from mickel8 and sgfn August 29, 2024 11:33
@LVala LVala merged commit 738771f into master Aug 29, 2024
3 checks passed
@LVala LVala deleted the optional-channels branch August 29, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants