Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use track id in get_stats #176

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Use track id in get_stats #176

merged 4 commits into from
Dec 3, 2024

Conversation

roznawsk
Copy link
Contributor

No description provided.

@roznawsk roznawsk requested a review from mickel8 November 28, 2024 10:25
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.93%. Comparing base (217519f) to head (f6d8a45).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/ex_webrtc/rtp_sender.ex 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   87.80%   87.93%   +0.13%     
==========================================
  Files          47       47              
  Lines        2370     2371       +1     
==========================================
+ Hits         2081     2085       +4     
+ Misses        289      286       -3     
Files with missing lines Coverage Δ
lib/ex_webrtc/rtp_receiver.ex 76.92% <ø> (ø)
lib/ex_webrtc/rtp_sender.ex 91.37% <0.00%> (+0.15%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 217519f...f6d8a45. Read the comment docs.

Copy link
Member

@mickel8 mickel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Track attached to the sender can be changed without creating a new sender (using replaceTrack function). I think we can store track id in a new field called mediaSourceId, see here

Could you also add trackIdentifier to the receiver stats?

@roznawsk roznawsk requested a review from mickel8 December 2, 2024 16:53
lib/ex_webrtc/rtp_sender.ex Outdated Show resolved Hide resolved
@mickel8 mickel8 merged commit abcf8d3 into master Dec 3, 2024
1 check failed
@mickel8 mickel8 deleted the use_track_id_in_get_stats branch December 3, 2024 16:36
@mickel8 mickel8 mentioned this pull request Dec 5, 2024
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants