Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide generate_data_mline function #188

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Hide generate_data_mline function #188

merged 1 commit into from
Jan 30, 2025

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Jan 30, 2025

This function should be private

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (f87341e) to head (1cfa2d9).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   84.72%   84.84%   +0.11%     
==========================================
  Files          49       49              
  Lines        2507     2507              
==========================================
+ Hits         2124     2127       +3     
+ Misses        383      380       -3     
Files with missing lines Coverage Δ
lib/ex_webrtc/peer_connection.ex 86.33% <ø> (+0.29%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87341e...1cfa2d9. Read the comment docs.

@mickel8 mickel8 requested a review from sgfn January 30, 2025 11:59
@mickel8 mickel8 merged commit 6850a28 into master Jan 30, 2025
3 checks passed
@mickel8 mickel8 deleted the fix-priv-func branch January 30, 2025 15:34
@mickel8 mickel8 mentioned this pull request Feb 7, 2025
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants