Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICECandidate.to_json and ICECandidate.from_json #62

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Jan 21, 2024

No description provided.

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Merging #62 (7f85ac4) into master (bf45f20) will decrease coverage by 0.50%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   88.57%   88.08%   -0.50%     
==========================================
  Files          25       26       +1     
  Lines        1068     1074       +6     
==========================================
  Hits          946      946              
- Misses        122      128       +6     
Files Coverage Δ
lib/ex_webrtc/ice_candidate.ex 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf45f20...7f85ac4. Read the comment docs.

@LVala LVala marked this pull request as ready for review February 1, 2024 10:15
@LVala LVala self-requested a review February 1, 2024 10:15
@LVala LVala merged commit c0754f8 into master Feb 1, 2024
4 checks passed
@LVala LVala deleted the ice-cand-json branch February 1, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants