Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet): enhance token provider implementation and type safety #3132

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

VolodymyrBg
Copy link
Contributor

Pull Request Title: feat(starknet): enhance token provider implementation and type safety

Relates to

This PR relates to improving the Starknet plugin's token provider implementation and type safety.

Risks

Low - The changes are mostly improvements to existing code and type definitions, with no breaking changes to the API.

Background

What does this PR do?

  1. Removes deprecated fetchWithRetry method
  2. Updates getTokensInWallet with proper Starknet support and caching
  3. Adds token-specific cache keys for better performance
  4. Initializes Starknet provider with mainnet configuration
  5. Adds comprehensive TypeScript declarations for better type safety
  6. Improves error handling and logging

What kind of change is this?

  • Improvements (misc. changes to existing features)
  • Bug fixes (removing deprecated code)

Documentation changes needed?

My changes do not require a change to the project documentation as they are internal improvements to the codebase.

Testing

Where should a reviewer start?

  1. Review the changes in packages/plugin-starknet/src/providers/token.ts
  2. Check the type declarations in packages/plugin-starknet/src/types/declarations.d.ts

Detailed testing steps

  1. Test token balance retrieval:
    const walletProvider = new WalletProvider(runtime);
    const provider = new TokenProvider(tokenAddress, walletProvider);
    const balances = await provider.getTokensInWallet();

  2. Verify caching behavior:
    typescript
    // First call should fetch from network
    const firstCall = await provider.getTokensInWallet();
    // Second call should return cached data
    const secondCall = await provider.getTokensInWallet();

  3. Test error handling:
    typescript
    // Should handle errors gracefully
    try {
    await provider.getTokensInWallet();
    } catch (error) {
    // Should provide meaningful error message
    console.error(error);
    }

Changes Summary

  • Removed deprecated code
  • Enhanced type safety
  • Improved caching mechanism
  • Better error handling
  • Proper Starknet provider initialization

The PR focuses on improving code quality and maintainability while ensuring type safety throughout the Starknet plugin implementation.

Copy link
Contributor

coderabbitai bot commented Feb 1, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

graphite-app bot commented Feb 1, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • merge-queue-hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant