Avoid recreating windows when only duration
changes
#1236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid recreating windows when only
duration
changes, and instead only updates the window close timer.This avoids possible flicker with windows such as OSDs. The logic to do this was added in #263 but broke when durations were added.
Fixes #260.
Usage
N/A
Showcase
N/A, but here's my OSD that was flickering (WIP, haven't figured out the scss to remove the margin above the progress):
Additional Notes
N/A
Checklist
Please make sure you can check all the boxes that apply to this PR.
docs/content/main
directory has been adjusted to reflect my changes. (N/A)cargo fmt
to automatically format all code before committing