Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid recreating windows when only duration changes #1236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bbb651
Copy link

@bbb651 bbb651 commented Nov 26, 2024

Description

Avoid recreating windows when only duration changes, and instead only updates the window close timer.
This avoids possible flicker with windows such as OSDs. The logic to do this was added in #263 but broke when durations were added.
Fixes #260.

Usage

N/A

Showcase

N/A, but here's my OSD that was flickering (WIP, haven't figured out the scss to remove the margin above the progress):

image

Additional Notes

N/A

Checklist

Please make sure you can check all the boxes that apply to this PR.

  • All widgets I've added are correctly documented. (N/A)
  • I added my changes to CHANGELOG.md, if appropriate. (N/A)
  • The documentation in the docs/content/main directory has been adjusted to reflect my changes. (N/A)
  • I used cargo fmt to automatically format all code before committing

This avoids possible flicker with windows such as OSDs.
The logic to do this was added in elkowar#263 but broke when durations were added.

Fixes elkowar#260.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] When opening an already opened widget it flickers
1 participant