Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: problem with usage of abstract type Class #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Umahizi
Copy link

@Umahizi Umahizi commented Nov 23, 2022

I stumbled upon the same issue as #36 and this is a proposed solution

@elsassph
Copy link
Owner

Looks reasonable - would you be able to add a test case for it?

@Umahizi
Copy link
Author

Umahizi commented Dec 13, 2022

The solution is not good, it fixes the building issues but renders the functionality unusable in typescript actually something like this is needed
if(t.name == "Class"){ dotName = "new () =>" +'${genericParams.join('')}'; } else { dotName += '<${genericParams.join(',')}>'; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants