Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Danish keyboard layout #85

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MagicBOTAlex
Copy link

@MagicBOTAlex MagicBOTAlex commented Jan 4, 2025

Issue [#80]

I told ya I would do it.
Kept my word.

This repo is surprisingly well organized. Good job

Copy link
Owner

@elvissteinjr elvissteinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, so I'm being pedantic in places here.
Some is opinionated and I don't know what a typical danish keyboard really looks like beyond what the internet tells me (which sometimes fools me on this topic).

Really blocking would only be the Enter key type.
Thanks!

assets/keyboards/qwerty_dk.ini Outdated Show resolved Hide resolved
assets/keyboards/qwerty_dk.ini Outdated Show resolved Hide resolved
assets/keyboards/qwerty_dk.ini Show resolved Hide resolved
assets/keyboards/qwerty_dk.ini Outdated Show resolved Hide resolved
assets/keyboards/qwerty_dk.ini Outdated Show resolved Hide resolved
@MagicBOTAlex
Copy link
Author

I'll be doing these changes in the near future, but tomorrow, uni starts again. And I foolishly choose double work so I can finish Uni faster. Thanks for feedback though. Idk, I'm just wandering around in this repo lol.

@MagicBOTAlex
Copy link
Author

Here's the layout but in screenshots, so easier for you to review:

normal

image

Shift

image

AltGr

image

Idk what happens with the numpad in altGr because I don't have a numpad lol

@elvissteinjr
Copy link
Owner

Idk what happens with the numpad in altGr because I don't have a numpad lol
What we had previously there was fine. Numpad should send numpad key codes in the AltGr layer as well. Software can decide what to do with that, though I guess it's usually not much.

Looks good to me otherwise.

@MagicBOTAlex
Copy link
Author

Oh, i read it wrong. I'll correct it next time

@MagicBOTAlex
Copy link
Author

Alright, how about this?
image

This is the AltGr layout

Sorry for this long wait. Life has been busy

@elvissteinjr
Copy link
Owner

Looks mostly good to me.

If you don't mind me being pedantic one last time, the numpad decimal/comma is missing on the AltGr layer. Checking with an input tester, there doesn't seem to be anything unusual with the key states of the numpad keys while holding AltGr on a real keyboard, so it'd make sense for all of them to remain available.

Also something I missed last time, the "" key's string seems to be set to print "\", so two characters. If there was an intent of escaping here, that is not necessary (only escaped things are newlines are as "\n" and literal "\n"s as "\n").

Don't worry about the speed of progress here. It's not like much has happened from my side recently either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants