Skip to content

Commit

Permalink
Fix: match behavior of declare linter to checkdoc (#272)
Browse files Browse the repository at this point in the history
* use eask-report so eask-strict-p flag is checked

* use inhibit-message to hide output from check-declare-file

* set allow-error=always in declare linter

* use eask--silent macro instead
  • Loading branch information
joshbax189 authored Oct 30, 2024
1 parent 073ce20 commit ffecfd7
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions lisp/lint/declare.el
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@

(defvar check-declare-warning-buffer)

;;
;;; Flags

(advice-add #'eask-allow-error-p :override #'always)

;;
;;; Core

Expand All @@ -34,10 +39,10 @@
(errors))
(eask-lint-first-newline)
(eask-msg "`%s` with check-declare" (ansi-green file))
(setq errors (check-declare-file filename))
(setq errors (eask--silent (check-declare-file filename)))
(if errors
(with-current-buffer check-declare-warning-buffer
(eask-msg (buffer-string)))
(eask-report (string-remove-prefix "\n" (buffer-string))))
(eask-msg "No issues found"))))

(eask-start
Expand Down

0 comments on commit ffecfd7

Please sign in to comment.