Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul command-line window #1830

Merged
merged 4 commits into from
Aug 27, 2023
Merged

Overhaul command-line window #1830

merged 4 commits into from
Aug 27, 2023

Commits on Aug 25, 2023

  1. Do not silence unused evil-define-command argument

    @axelf4
    axelf4 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    284232a View commit details
    Browse the repository at this point in the history

  2. Add evil-command-line-map 

    There was a lot of duplication between evil-ex-completion-map and
evil-ex-search-keymap, which meant that any rebinds had to be done
twice. This commit fixes that by introducing evil-command-line-map as
a common ancestor of the two keymaps.

Also renames evil-ex-map to evil-ex-shortcut-map to avoid confusion,
as its purpose is more niche than evil-ex-completion-map which
functions the same as any other keymap passed to read-from-minibuffer.
    @axelf4
    axelf4 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    b6daa76 View commit details
    Browse the repository at this point in the history

  3. Reselect minibuffer when quitting command-line win 

    Pressing C-f while editing an Ex command to open the command-line
window and later quitting that window used to not reselect the Ex
command line, but instead just continue the recursive edit in some
previous window. This was specially confusing before commit
02004bc, as the evil-ex-abort hack
did not trigger, leaving you in a bad state with
evil-ex-current-buffer set to t.

This commit fixes that by setting the delete-window window parameter
on the command-line window to a function that switches back to the
minibuffer after deleting the window, which closes emacs-evil#1379.

This commit also replaces the split-window call with a display-buffer
invocation, to always spawn the window at the bottom of the frame, but
also allow the user to override this behavior.
    @axelf4
    axelf4 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    1102686 View commit details
    Browse the repository at this point in the history

  4. Support command-line window for any minibuffer arg 

    Introspection of the current minibuffer argument history and prompt is
possible, hence there is no need for the specialized
evil-ex-command-window and evil-ex-search-command-window functions.
    @axelf4
    axelf4 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    079cbc6 View commit details
    Browse the repository at this point in the history