helm-org-insert-link-to-heading-at-marker now supports ID properties #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This have been accomplished by rewriting the function in order for it to use org-store-link and org-insert-last-stored-link. Thus, the user is able to decide whether headlines must be referenced through their IDs (by setting org-id-link-to-org-use-id to t) or through their names.
|
@rdrg109 Please look carefully at the code you have removed. You appear to have omitted some important parts that set the buffer. I don't think the code you wrote will work correctly in all cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #25 and is a shorter rewriting of #23.
This have been accomplished by rewriting the function in order for it
to use org-store-link and org-insert-last-stored-link. Thus, the user
is able to decide whether headlines must be referenced through their
IDs (by setting org-id-link-to-org-use-id to t) or through their
names.
When submitting a pull request, please include the following information:
helmversions tested with: 20210324.1927helm-coreversions tested with: 20210704.556Note that Emacs and Org versions persist "in the wild" for some time after release, so it is not appropriate to only test with the latest released or development versions of Org; tests must include versions still commonly in use. Proposed changes must not break functionality for existing users.