-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement incremental checking based on built-in sentence navigation #24
base: master
Are you sure you want to change the base?
Conversation
df18bba
to
18ed07e
Compare
@jcs090218 I think this is finally in a good place for a real review. Whenever you have time can you take a look and try it out? There are still many areas I wish to refactor/optimize; however, it'll be better to get more eyes on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a compile warning:
flymake-languagetool.el:443:16: Warning: reference to free variable ‘forward-sentence-function’
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM!
I didn't check the functionalities, but you have been very responsive, so I think I can trust you. Feel free to merge it when it's ready! :)
220bbbd
to
b8e871f
Compare
@jcs090218 Is there any way to get the Windows-latest snapshot test to actually run? I have seen that it always fails at the |
No, unfortunately. For more info, see emacs-eask/cli#224. |
This allows us to send only partial chunks of text to the server instead of sending the entire buffer for each modification to the buffer.
Not sure why `setq-local' was giving me issues, but using the generalized `setf' seems to work.
888f4bd
to
bc6afc5
Compare
@jcs090218 I was going to merge this PR, but I'm not certain why all the macOS tests are failing - there is not much information in logs. Whenever you have time, can you take a look? |
I've re-run the test. It looks good now! ;) |
Any progress on this? Will it be merged? It looks like only one Windows test is failing. |
This allows us to send only partial chunks of text to the server
instead of sending the entire buffer for each modification to the
buffer.