Fix #41 weblorg-export warning in interactive mode #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markokocic
force-pushed
the
org-parse-refactor
branch
from
9871c85 to
1fbf3ac
Compare
|
Looks like it breaks unit tests. I will need to check further. |
markokocic
force-pushed
the
org-parse-refactor
branch
from
1fbf3ac to
ca1c517
Compare
Mark temp buffer as non-modified to silence prompt when closing it in interactive mode.
markokocic
force-pushed
the
org-parse-refactor
branch
from
ca1c517 to
2f21073
Compare
|
Ok, this version passes all unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By replacing with-temp-buffer with with-temp-file in weblorg--parse-org the warning when closing buffer/file in interactive mode is gone.
I tested it locally, and it doesn't seem to break anything.
@clarete @nanzhong can you please review before merging?