Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: inline completions #4623

Merged
merged 46 commits into from
Dec 1, 2024
Merged
Show file tree
Hide file tree
Changes from 34 commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
361255a
fix: avoid calling line-number-at-pos with a value past the end of th…
kassick Nov 18, 2024
5caf44c
feat: Inline Completion support
kassick Nov 18, 2024
7227d67
feat: Inline Completion default UI
kassick Nov 19, 2024
33025a0
feat: do not consume the key used to cancel the current inline comple…
kassick Nov 25, 2024
9c5fc21
feat: better positioning of the cursor when the inline completion is …
kassick Nov 25, 2024
2b9d47d
chore: do not warn of no suggestions when implicit
kassick Nov 25, 2024
5ee78c1
feat: provide a minor mode for auto activating inline completions
kassick Nov 25, 2024
b4f0c7c
chore: avoid linter errors
kassick Nov 25, 2024
f5b572b
feat: better cursor positioning on accept
kassick Nov 25, 2024
f9783fd
fix: forward prefix arg
kassick Nov 25, 2024
828875b
fix: wrong function name
kassick Nov 25, 2024
d3ff223
fix: wrong number of arguments
kassick Nov 25, 2024
8f13826
chore: use cl-map to avoid linting issues
kassick Nov 25, 2024
1d4b7c8
fix: avoid weird interactions with company-mode
kassick Nov 26, 2024
063fd89
refactor: split parse and request -- may be handy in async
kassick Nov 26, 2024
5f67185
fix: use current active map instead of global map
kassick Nov 26, 2024
3bab211
fix: add external references
kassick Nov 26, 2024
da2d8c2
feat: provide a method to inhibit inline completion mode
kassick Nov 26, 2024
64e6a77
chore: remove debug
kassick Nov 26, 2024
a1e7d7d
chore: keep interfaces sorted in lsp-protocol.el
kassick Nov 27, 2024
92281ed
refactor: declare and use InlineCompletionParams and InlineCompletion…
kassick Nov 27, 2024
55d086a
fix: do not assume that the server response is a hash table
kassick Nov 27, 2024
0e81d72
refactor: move lsp-inline-completion-mode outside of lsp-mode.el
kassick Nov 27, 2024
a74edd4
refactor: extract company integration to a minor mode
kassick Nov 27, 2024
80e210a
refactor: use autoload to configure inline completions mode
kassick Nov 27, 2024
3c43167
fix: ensure the callback is still executing in the context of the ori…
kassick Nov 27, 2024
612e90e
chore: use local variables for the company integration minor mode
kassick Nov 27, 2024
b19a8f1
chore: remove ht as dependency
kassick Nov 27, 2024
231b867
fix: variable name
kassick Nov 27, 2024
49895b7
fix: define minor mode before the functions that need to check for it
kassick Nov 27, 2024
312626e
chore: add missing type to custom variable
kassick Nov 27, 2024
79dd07c
fix: declare company--begin-inhibit-commands as a variable
kassick Nov 27, 2024
e20df27
chore: do not use make-variable-buffer-local
kassick Nov 27, 2024
f2b38e0
fix: use cl-map to make the compiler happy
kassick Nov 27, 2024
08c4c8d
fix: ensure no state changes before triggering inline completion
kassick Nov 28, 2024
c560275
chore: no spinner on implicit inline completions
kassick Nov 28, 2024
3eeb087
chore: always cancel timer
kassick Nov 28, 2024
509f8ee
chore: autoload keymap
kassick Nov 28, 2024
69e2fa3
chore: always show keys/status during active completion
kassick Nov 28, 2024
8a5dc5c
fix: autoload minor modes
kassick Nov 28, 2024
86abb87
chore: fix indentation
kassick Nov 28, 2024
a4243c2
chore: lsp--info when explicit completion request did not return
kassick Nov 28, 2024
2b582bd
chore: make show-keys private
kassick Nov 28, 2024
13f340c
chore: update default keymap
kassick Nov 28, 2024
b4cff81
feat: on click, place the cursor at the correct point after completion
kassick Nov 28, 2024
a109f34
chore: make suggestion insertion undoable
kassick Nov 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading