[feat] Handling nimlangserver extension/statusUpdate
#4628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why?: - Since version 1.6.0 `nimlangserver` periodically sends an `extension/statusUpdate` notification which triggers a warning by `lsp-mode`. Because of the notification being sent quite frequently it prevents the user from actually being able to work on a Nim file. So, at the moment we should just ignore the notification which can still be inspected when setting `lsp-log-io` to `t`. This change addresses the need by: - Add notification handler #'ignore to `lsp-nim.el` for `extension/statusUpdate`
jcs090218
approved these changes
Nov 28, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?:
nimlangserverperiodically sends anextension/statusUpdatenotification which triggers a warning bylsp-mode. Because of the notification being sent quite frequently it prevents the user from actually being able to work on a Nim file. So, at the moment we should just ignore the notification which can still be inspected when settinglsp-log-iotot.This change addresses the need by:
lsp-nim.elforextension/statusUpdate