New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsp-inline-completion: cleanup autoload to make it loads correctly #4633

Merged

kiennq merged 1 commit into emacs-lsp:master from kiennq:bug/inline-comp-autoload

Dec 2, 2024

Member

kiennq commented Dec 1, 2024

Make lsp-inline-completion-enable be autoloaded so it will be evaluated correctly in the add-hook autoload.
Also, do a few other cleanups:

Add lsp-completion-enable as autoload and remove its definition from lsp-mode.el
Remove autoload from lsp-inline-completion-active-map and lsp-inline-completion-overlay-face. They can be loaded with require lsp-inline-completion
Move lsp-inline-completion--with-undo-amalgamate to lsp-with-undo-amalgamate.


          lsp-inline-completion: cleanup autoload to make it loads correctly

41e50cc

github-actions bot added the completion label

jcs090218 approved these changes

View reviewed changes

kiennq merged commit c3be413 into emacs-lsp:master

10 of 13 checks passed

danielpza mentioned this pull request

Error running timer: (void-variable lsp-inline-completion-enable) #4636

Open

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels