Tests to verify JavaScript, (some) TypeScript, and Rust calculations #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs090218
approved these changes
Apr 13, 2024
|
Thank you so much! 🚀 Let me know if you are willing to help maintain this package since you have recently sent multiple high-quality patches. :) |
Sure 🙂 I would love to help out with maintaining this package! 😄 |
|
Awesome! I've invited you to the group! 🥳 I have the branch protection rules set up first, so you must still have at least one approval before merging. Once you are fully qualified, I will give you full control over the repo. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the title says. The TypeScript tests are minimal, as most of our support already builds on JavaScript. Might add more later, but didn't really feel motivating as it would be pretty much the same as JavaScript. JavaScript and Rust tests are more complete, testing most of the rules.
Also fix a minor issue with anonymous functions not working properly due to wrong node name in JavaScript.