Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make up-item smart #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

aki2o
Copy link
Contributor

@aki2o aki2o commented Feb 10, 2014

I suppose it's better to move the parent directory if the root directory of the direx buffer has a parent directory.

I tested that the changed behavior of this pull request is up to my expectation.
But, I'm not sure whether the following code in direx:up-item is OK or not.

(erase-buffer)
(direx:add-root-into-buffer it (current-buffer))
(rename-buffer (direx:tree-name it) t))

Does this code give any bad effect to the other function of direx?

Best regards.

@aki2o
Copy link
Contributor Author

aki2o commented Feb 10, 2014

BTW, The following message was shown on the web page of Github when I send this pull request.

Error checking merge status
Don't worry, you can still submit the pull request

Does this pull request have any problem?

@m2ym
Copy link
Contributor

m2ym commented Mar 23, 2014

Commented on the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants