Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed quickrun duplicating the source buffer on multiple runs #94

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pickardjoe
Copy link

This should fix #75.

Copy link
Collaborator

@jcs090218 jcs090218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor review.

Sorry for the late review! 😅

"Kill quickrun buffer."
(when (get-buffer quickrun--buffer-name)
(kill-buffer quickrun--buffer-name)))
(let (quickrun--buffer (get-buffer quickrun--buffer-name))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a syntax error over here? Can you check this? Thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this patch works? The variable quickrun--buffer will always return nil hence it will never run. 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

quickrun leaves an empty buffer each time
2 participants