Starting to bring service class down into driver creation for various…

… browsers

The is just an in ititial commit with some changes which bring the service class down to
the point where we create/instantiate the webdrivers for the for the various browsers.
Still need some work to actually use what the user provides and to test this code.

src/SeleniumLibrary/keywords/browsermanagement.py

@@ -68,6 +68,7 @@ def open_browser(
         options: Any = None,
         service_log_path: Optional[str] = None,
         executable_path: Optional[str] = None,
+        service: Any = None,
     ) -> str:
         """Opens a new browser instance to the optional ``url``.
 
@@ -279,6 +280,10 @@ def open_browser(
             return index
         if desired_capabilities:
             self.warn("desired_capabilities has been deprecated and removed. Please use options to configure browsers as per documentation.")
+        if service_log_path:
+            self.warn("service_log_path is being deprecated. Please use service to configure log_output or equivalent service attribute.")
+        if executable_path:
+            self.warn("exexcutable_path is being deprecated. Please use service to configure the driver's executable_path as per documentation.")
         return self._make_new_browser(
             url,
             browser,
@@ -289,6 +294,7 @@ def open_browser(
             options,
             service_log_path,
             executable_path,
+            service,
         )
 
     def _make_new_browser(
@@ -302,6 +308,7 @@ def _make_new_browser(
         options=None,
         service_log_path=None,
         executable_path=None,
+        service=None,
     ):
         if remote_url:
             self.info(
@@ -318,6 +325,7 @@ def _make_new_browser(
             options,
             service_log_path,
             executable_path,
+            service,
         )
         driver = self._wrap_event_firing_webdriver(driver)
         index = self.ctx.register_driver(driver, alias)
@@ -763,6 +771,7 @@ def _make_driver(
         options=None,
         service_log_path=None,
         executable_path=None,
+        service=None,
     ):
         driver = self._webdriver_creator.create_driver(
             browser=browser,
@@ -772,6 +781,7 @@ def _make_driver(
             options=options,
             service_log_path=service_log_path,
             executable_path=executable_path,
+            service=service,
         )
         driver.set_script_timeout(self.ctx.timeout)
         driver.implicitly_wait(self.ctx.implicit_wait)

src/SeleniumLibrary/keywords/webdrivertools/webdrivertools.py

@@ -69,6 +69,7 @@ def create_driver(
         options=None,
         service_log_path=None,
         executable_path=None,
+        service=None,
     ):
         browser = self._normalise_browser_name(browser)
         creation_method = self._get_creator_method(browser)
@@ -89,13 +90,15 @@ def create_driver(
                 options=options,
                 service_log_path=service_log_path,
                 executable_path=executable_path,
+                service=service,
             )
         return creation_method(
             desired_capabilities,
             remote_url,
             options=options,
             service_log_path=service_log_path,
             executable_path=executable_path,
+            service=service,
         )
 
     def _get_creator_method(self, browser):
@@ -148,6 +151,7 @@ def create_chrome(
         options=None,
         service_log_path=None,
         executable_path="chromedriver",
+        service=None,
     ):
         if remote_url:
             if not options:
@@ -169,6 +173,7 @@ def create_headless_chrome(
         options=None,
         service_log_path=None,
         executable_path="chromedriver",
+        service=None,
     ):
         if not options:
             options = webdriver.ChromeOptions()