Fix crashing on launch due to R8 #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235
Type of change
This PR adds default proguard rules provided by Android SDK. Without these rules, important methods and classes get removed, for example Parcelable implementation of FragmentManagerState. Additional information can be found in streetcomplete/StreetComplete#2003.
I tried to keep the configuration that was specified in postprocessing {} block as it is not compatible with default proguard rules. Let me know if there are any changes.
Also, I bumped Java version to 11 as the proguard issues reported in #192 should be fixed with default rules. I don't experience any crashes on release build with that setup.