Browser tests #370
Merged
Browser tests #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfirsh
force-pushed
the
browser-tests
branch
6 times, most recently
from
feca69f to
6d4b97d
Compare
jonathan-s
approved these changes
Feb 7, 2019
| @@ -2301,15 +2301,17 @@ def process_unsaved_booking(request): | |||
| return | |||
|
|
|||
|
|
|||
| def user_login(request): | |||
| def user_login(request, username=None): | |||
There was a problem hiding this comment.
I would suggest that we use https://djangopackages.org/packages/p/django-registration/ for registration / login. If you agree let's open a new issue for that.
There was a problem hiding this comment.
Yes sounds good! These views looked like a bit of a mess but I didn’t want to refactor them now. 🙈
There was a problem hiding this comment.
There will come a day :)
There was a problem hiding this comment.
yes agree! this project was started before django had a registration or profile functionality built in. have been keen to move to the newer functionality.
jonathan-s
reviewed
Feb 7, 2019
|
|
||
| We use [Cypress](https://www.cypress.io/) to test the high-level features of Modernomad in a browser. This checks that the frontend code and backend code all work together from the level of a user clicking around on the site. | ||
|
|
||
| Cypress needs to run on your local machine, not inside Chrome or a VM, because it has to start and control your browser. |
There was a problem hiding this comment.
Perhaps it would be worth making a note that it needs to run on a clean install, using generate_test_data command?
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a robot that clicks through the website!
This is using Cypress which is so so much nicer than the selenium tests of old. The test results are available on the web! They have screenshots and video to debug! (Link is at end of Travis log output.)
There are various other changes in this PR, so you might want to click through the commits one by one to review. I've organised them carefully for that reason.
fixes #302
fixes #339