-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --benchmark and --exclude option to the benchmark scripts for debugging #145
base: master
Are you sure you want to change the base?
Conversation
This is an interesting approach, since I know from practical work that often you use a subset of Embench in practical projects. We need to be clear that any result with a subset is not a valid Embench score, but it can still be very useful. I've asked @PaoloS02 to review your patch. |
I agree with you.
Thank you. |
Thanks for this @hirooih , |
If @hirooih is happy with your change, then so am I. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
Thanks!
…valid results. fixes proposed by @PoaloS02
75ba157
to
f6e075d
Compare
I've added the commit proposed by @PaoloS02 and fixed conflicts which was caused after the original commit. |
This PR adds
--benchmark
and--exclude
option tobuild_all.py
,benchmark_size.py
, andbenchmark_speed.py
.For example
--benchmark md5sum tarfind
option builds or measures onlymd5sum
andtarfind
tests.--exclude md5sum tarfind
option builds or measures all tests except formd5sum
andtarfind
.This was quite useful for debugging.