Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --benchmark and --exclude option to the benchmark scripts for debugging #145

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hirooih
Copy link
Contributor

@hirooih hirooih commented Oct 10, 2021

This PR adds --benchmark and --exclude option to build_all.py, benchmark_size.py, and benchmark_speed.py.
For example --benchmark md5sum tarfind option builds or measures only md5sum and tarfind tests.
--exclude md5sum tarfind option builds or measures all tests except for md5sum and tarfind.

This was quite useful for debugging.

@jeremybennett
Copy link
Collaborator

This is an interesting approach, since I know from practical work that often you use a subset of Embench in practical projects. We need to be clear that any result with a subset is not a valid Embench score, but it can still be very useful. I've asked @PaoloS02 to review your patch.

@hirooih
Copy link
Contributor Author

hirooih commented Oct 16, 2021

We need to be clear that any result with a subset is not a valid Embench score,

I agree with you.
We added new tests after 1.0 release. We can also use --exclude option to compare a result with results for 1.0 release.

I've asked @PaoloS02 to review your patch.

Thank you.

@PaoloS02
Copy link
Contributor

Thanks for this @hirooih ,
I took the liberty to add a commit on your branch with warning messages that clarify that subsets of the benchsuite don't generate valid results. If it is phrased satisfactorily @jeremybennett I think this patch can be merged. I tested it and it works well.
Btw I quite agree this options are useful. I've been moving tests to temporary folders lately to focus on debugging a subset.

@jeremybennett
Copy link
Collaborator

Thanks for this @hirooih , I took the liberty to add a commit on your branch with warning messages that clarify that subsets of the benchsuite don't generate valid results. If it is phrased satisfactorily @jeremybennett I think this patch can be merged. I tested it and it works well. Btw I quite agree this options are useful. I've been moving tests to temporary folders lately to focus on debugging a subset.

If @hirooih is happy with your change, then so am I.

Copy link
Contributor Author

@hirooih hirooih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
Thanks!

@hirooih
Copy link
Contributor Author

hirooih commented Jan 17, 2023

I've added the commit proposed by @PaoloS02 and fixed conflicts which was caused after the original commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants